opus.git
7 years agoInclude the doc dir in DIST_SUBDIRS instead of EXTRA_DIST
Ron [Mon, 11 Jun 2012 19:10:42 +0000 (04:40 +0930)]
Include the doc dir in DIST_SUBDIRS instead of EXTRA_DIST

And explicitly specify what we want included in EXTRA_DIST of doc/Makefile.am,
otherwise make dist picks up whatever random junk you might have laying around
in that dir at the time you run it.

Tweak the top level delegation targets, because this means distclean will be
run in the doc dir by default now without our help.

7 years agoopus_compare.m was outdated
Jean-Marc Valin [Mon, 11 Jun 2012 18:37:44 +0000 (14:37 -0400)]
opus_compare.m was outdated

7 years agoDon't bark scary warnings at compile time about no doxygen
Ron [Wed, 23 May 2012 05:45:19 +0000 (15:15 +0930)]
Don't bark scary warnings at compile time about no doxygen

We already report whether or not the docs will be built in the summary box
at the end of the configure run.

7 years agoFixup paths in doc/
Gregory Maxwell [Mon, 11 Jun 2012 17:33:35 +0000 (13:33 -0400)]
Fixup paths in doc/

7 years agoPretty up the HTML doxygen output.
Gregory Maxwell [Mon, 11 Jun 2012 05:42:32 +0000 (01:42 -0400)]
Pretty up the HTML doxygen output.

7 years agoAdd brief descriptions to the encode/decode groups to avoid weird autobreif strings.
Gregory Maxwell [Mon, 11 Jun 2012 01:30:01 +0000 (21:30 -0400)]
Add brief descriptions to the encode/decode groups to avoid weird autobreif strings.

7 years agoCorrect documentation in opus_custom.h.
Gregory Maxwell [Mon, 11 Jun 2012 01:15:02 +0000 (21:15 -0400)]
Correct documentation in opus_custom.h.

7 years agoRemove unnecessary and not-very-portable opus_demo case insensitivity.
Gregory Maxwell [Fri, 18 May 2012 00:04:42 +0000 (20:04 -0400)]
Remove unnecessary and not-very-portable opus_demo case insensitivity.

7 years agoFix doxygen docs wrt OPUS_WARN_UNUSED_RESULT and OPUS_ARG_NONNULL.
Gregory Maxwell [Sat, 2 Jun 2012 06:15:49 +0000 (02:15 -0400)]
Fix doxygen docs wrt OPUS_WARN_UNUSED_RESULT and OPUS_ARG_NONNULL.

Also get the subname rigtht.

7 years agoUpdate headers to cause warnings on unused returns and null args.
Gregory Maxwell [Fri, 1 Jun 2012 06:21:53 +0000 (02:21 -0400)]
Update headers to cause warnings on unused returns and null args.

In places where an ignored return or a null-arg is a sure indication
of a bug add the GCC warning attributes. The null arg annotation
is not enable for Opus itself because it will cause the compiler
to optimize out some null checks. I don't trust our callers
quite that much.

7 years agomodified the Visual Studio 2010 projects and solution file to include a x64 configura...
root [Fri, 1 Jun 2012 16:48:01 +0000 (12:48 -0400)]
modified the Visual Studio 2010 projects and solution file to include a x64 configuration. modified the output folders such that the architecture is included in the path (so you get Release64, Debug32, etc.) so you can have all build types in one tree.

7 years ago Avoid an inconsequential memory leak in tests/test_opus_decode.c
Gregory Maxwell [Fri, 1 Jun 2012 06:27:36 +0000 (02:27 -0400)]
 Avoid an inconsequential memory leak in tests/test_opus_decode.c

7 years agoAvoid an inconsequential memory leak in tests/test_opus_encode.c.
Gregory Maxwell [Fri, 1 Jun 2012 04:46:57 +0000 (00:46 -0400)]
Avoid an inconsequential memory leak in tests/test_opus_encode.c.

7 years agoSeems like using dllimport on Windows wasn't useful
Jean-Marc Valin [Thu, 31 May 2012 15:50:33 +0000 (11:50 -0400)]
Seems like using dllimport on Windows wasn't useful

This was a problem for static builds

7 years agoFix for building mingw32 apps.
Gregory Maxwell [Wed, 30 May 2012 18:36:02 +0000 (14:36 -0400)]
Fix for building mingw32 apps.

7 years agoAdvertise the static library for uninstalled builds.
Ralph Giles [Wed, 30 May 2012 18:06:26 +0000 (11:06 -0700)]
Advertise the static library for uninstalled builds.

It's less surprising for people using the -uninstalled
pkg-config file if we advertise the static library rather
than the shared build. That way the executables work without
having to hack the same location into LD_LIBRARY_PATH, and
the resulting binaries are easier to distribute.

For this to actually work with opus-tools, the -fPIE had
to be turned off, as it was in 1d128b4d5c6f. Support
for static PIE builds would be restored if we compiled
libopus.a with -fPIC.

Also remove the private header locations. These are no
longer required to declare any of the public api.

7 years agoFixes some cases where MIN/MAX macros result in duplicated function calls
Jean-Marc Valin [Tue, 29 May 2012 21:01:35 +0000 (17:01 -0400)]
Fixes some cases where MIN/MAX macros result in duplicated function calls

Also enforces an upper bound of 510 kb/s even for frames that are
smaller than 20 ms. This reduces waste for high bitrate VBR.

7 years agoFix opus-uninstalled.pc.
Timothy B. Terriberry [Tue, 29 May 2012 03:10:48 +0000 (20:10 -0700)]
Fix opus-uninstalled.pc.

With these changes, opus-tools can actually build using it.

7 years agoAdd extern "C" protection to opus_multistream.h.
Ralph Giles [Wed, 23 May 2012 23:33:14 +0000 (16:33 -0700)]
Add extern "C" protection to opus_multistream.h.

Unlike the other headers, opus_multistream.h didn't declare
itself to be C code, causing confusing errors when the caller
tries to use the functions from C++.

7 years agoUse 'frame' instead of 'signal', take out stdlib.h in silk/.
Gregory Maxwell [Wed, 23 May 2012 05:52:39 +0000 (01:52 -0400)]
Use 'frame' instead of 'signal', take out stdlib.h in silk/.

On MacOS, stdlib.h ends up including sys/signal.h, generating
warnings about the local variables called 'signal' shadowing
the global symbol signal(3).

This was originally done in 86476906 but it missed some use
of 'signal' in prototypes in headers where it didn't cause
warnings. Later the prototypes were moved around and the
warnings came back.

This also cleans up some cases in where stdlib.h was used
but shouldn't be required.

7 years agoEnable building just the library (or just the docs)
Ron [Mon, 21 May 2012 13:46:39 +0000 (23:16 +0930)]
Enable building just the library (or just the docs)

Both are still built and installed by default though.

7 years agoActually install the documentation with make install
Ron [Mon, 21 May 2012 13:44:50 +0000 (23:14 +0930)]
Actually install the documentation with make install

Instead of just its build stamp :)

7 years agoTweak doxygen input so that the manpage names won't conflict.
Gregory Maxwell [Sun, 20 May 2012 23:28:45 +0000 (19:28 -0400)]
Tweak doxygen input so that the manpage names won't conflict.

7 years agoint vs opus_int32 consistency
Jean-Marc Valin [Fri, 18 May 2012 19:14:17 +0000 (15:14 -0400)]
int vs opus_int32 consistency

7 years agoRemove the obsolete LIBOPUS_SUFFIX define.
Ralph Giles [Fri, 18 May 2012 19:01:46 +0000 (12:01 -0700)]
Remove the obsolete LIBOPUS_SUFFIX define.

As best we recall, this was used to version the
library filename during rapid development. It's
no longer needed now that the bitstream is frozen
and isn't hooked up to anything in the build system.

7 years agoMove the various version defines to be together.
Ralph Giles [Fri, 18 May 2012 18:47:58 +0000 (11:47 -0700)]
Move the various version defines to be together.

The config.h version defines were declared in the
middle of the math feature testing. This commit moves
it to the top of configure.ac where the other version
number code resides.

7 years agoMinor doc improvement wrt OPUS_APPLICATION_RESTRICTED_LOWDELAY.
Gregory Maxwell [Thu, 17 May 2012 00:00:32 +0000 (20:00 -0400)]
Minor doc improvement wrt OPUS_APPLICATION_RESTRICTED_LOWDELAY.

7 years agoSync with draft -14
Jean-Marc Valin [Thu, 17 May 2012 23:45:10 +0000 (19:45 -0400)]
Sync with draft -14

7 years agoFixes the stereo_analysis() fixed-point overflow issue properly
Jean-Marc Valin [Wed, 16 May 2012 21:47:17 +0000 (17:47 -0400)]
Fixes the stereo_analysis() fixed-point overflow issue properly

7 years agoMerge branch 'tmp_draft'
Jean-Marc Valin [Wed, 16 May 2012 04:36:19 +0000 (00:36 -0400)]
Merge branch 'tmp_draft'

Conflicts:
README

7 years agoRevert "Adds 3rd clause to CELT license"
Jean-Marc Valin [Wed, 16 May 2012 04:29:02 +0000 (00:29 -0400)]
Revert "Adds 3rd clause to CELT license"

This reverts commit 9f407afad6da25f87c2350e86b21151578ac2ed4.

7 years agoversion bump draft-13 v0.9.11
Jean-Marc Valin [Tue, 15 May 2012 23:58:28 +0000 (19:58 -0400)]
version bump

7 years agoRemove trailing whitespace from draft-ietf-codec-opus.xml.
Gregory Maxwell [Tue, 15 May 2012 23:23:36 +0000 (19:23 -0400)]
Remove trailing whitespace from draft-ietf-codec-opus.xml.

7 years agocommas
Kat Walsh [Tue, 15 May 2012 22:06:10 +0000 (18:06 -0400)]
commas

7 years agoTable title capitalization
Jean-Marc Valin [Tue, 15 May 2012 22:05:49 +0000 (18:05 -0400)]
Table title capitalization

7 years agodraft copyediting
Kat Walsh [Tue, 15 May 2012 21:50:40 +0000 (17:50 -0400)]
draft copyediting

7 years agomisc draft fixes
Jean-Marc Valin [Tue, 15 May 2012 20:51:22 +0000 (16:51 -0400)]
misc draft fixes

7 years agoMore minor gen-art part 2 edits.
Timothy B. Terriberry [Tue, 15 May 2012 20:45:40 +0000 (13:45 -0700)]
More minor gen-art part 2 edits.

Includes the addition of a band-layout table.

7 years agoApparently the tar compatibility option has compatibility problems!
Jean-Marc Valin [Tue, 15 May 2012 20:31:50 +0000 (16:31 -0400)]
Apparently the tar compatibility option has compatibility problems!

7 years agoMake vararray and restrict checks fail GCC 2.95.3's broken implementation.
Gregory Maxwell [Mon, 14 May 2012 05:58:05 +0000 (01:58 -0400)]
Make vararray and restrict checks fail GCC 2.95.3's broken implementation.

7 years agoImprove portability to BeOS via some configure.ac fixes and cleanups.
Gregory Maxwell [Mon, 14 May 2012 04:30:34 +0000 (00:30 -0400)]
Improve portability to BeOS via some configure.ac fixes and cleanups.

7 years agoAlt. compile instructions in the draft should match the Makefile.
Gregory Maxwell [Sun, 13 May 2012 01:42:03 +0000 (21:42 -0400)]
Alt. compile instructions in the draft should match the Makefile.

7 years agoGen-art (bit allocation work).
Jean-Marc Valin [Tue, 15 May 2012 20:13:18 +0000 (16:13 -0400)]
Gen-art (bit allocation work).

Also, make the archive work with older versions of tar

7 years agoGen-art part2
Jean-Marc Valin [Tue, 15 May 2012 18:46:21 +0000 (14:46 -0400)]
Gen-art part2

7 years agoGen-art update
Jean-Marc Valin [Tue, 15 May 2012 16:22:12 +0000 (12:22 -0400)]
Gen-art update

7 years agoGen-art part2
Timothy B. Terriberry [Tue, 15 May 2012 14:51:59 +0000 (10:51 -0400)]
Gen-art part2

7 years agodraft: reference for LSP stability
Jean-Marc Valin [Tue, 15 May 2012 14:49:41 +0000 (10:49 -0400)]
draft: reference for LSP stability

7 years agoMake vararray and restrict checks fail GCC 2.95.3's broken implementation.
Gregory Maxwell [Mon, 14 May 2012 05:58:05 +0000 (01:58 -0400)]
Make vararray and restrict checks fail GCC 2.95.3's broken implementation.

7 years agoImprove portability to BeOS via some configure.ac fixes and cleanups.
Gregory Maxwell [Mon, 14 May 2012 04:30:34 +0000 (00:30 -0400)]
Improve portability to BeOS via some configure.ac fixes and cleanups.

7 years agoRemove unused headers/defines in silk/typedef.h, improving portability to AMIX4.0...
Gregory Maxwell [Sun, 13 May 2012 23:17:16 +0000 (19:17 -0400)]
Remove unused headers/defines in silk/typedef.h, improving portability to AMIX4.0/GCC1.4.

7 years agoAdd #errors when !OPUS_BUILD or !(VAR_ARRAYS||USE_ALLOCA||NONTHREADSAFE_PSEUDOSTACK).
Gregory Maxwell [Sun, 13 May 2012 15:40:19 +0000 (11:40 -0400)]
Add #errors when !OPUS_BUILD or !(VAR_ARRAYS||USE_ALLOCA||NONTHREADSAFE_PSEUDOSTACK).

This will help prevent people using non-standard build environments from
footgunning themselves and becoming a support burden.

7 years agoSILK to print error line with FIXED_DEBUG, assert with FIXED_DEBUG_ASSERT.
Gregory Maxwell [Sun, 13 May 2012 15:14:11 +0000 (11:14 -0400)]
SILK to print error line with FIXED_DEBUG, assert with FIXED_DEBUG_ASSERT.

7 years agoWhen FIXED_DEBUG_ASSERT CELT will assert on fixed-debug error.
Gregory Maxwell [Sun, 13 May 2012 15:10:58 +0000 (11:10 -0400)]
When FIXED_DEBUG_ASSERT CELT will assert on fixed-debug error.

7 years agoGen-art sync
Jean-Marc Valin [Mon, 14 May 2012 22:30:48 +0000 (18:30 -0400)]
Gen-art sync

7 years agoMore on Gen-art part2
Jean-Marc Valin [Mon, 14 May 2012 21:56:26 +0000 (17:56 -0400)]
More on Gen-art part2

7 years agoSome Gen-art part2 changes
Jean-Marc Valin [Mon, 14 May 2012 20:28:33 +0000 (16:28 -0400)]
Some Gen-art part2 changes

7 years agoGen-art changes
Timothy B. Terriberry [Mon, 14 May 2012 02:16:44 +0000 (22:16 -0400)]
Gen-art changes

7 years agoMinor genart update
Jean-Marc Valin [Sat, 12 May 2012 04:29:13 +0000 (00:29 -0400)]
Minor genart update

7 years agoMore Gen-art changes
Jean-Marc Valin [Fri, 11 May 2012 20:31:54 +0000 (16:31 -0400)]
More Gen-art changes

7 years agoMore Gen-art changes
Jean-Marc Valin [Fri, 11 May 2012 20:00:45 +0000 (16:00 -0400)]
More Gen-art changes

7 years agoFirst set of changes for Gen-art review
Jean-Marc Valin [Fri, 11 May 2012 17:41:41 +0000 (13:41 -0400)]
First set of changes for Gen-art review

7 years agoFixes a fixed-point overflow by scaling pitch search more conservatively
Jean-Marc Valin [Fri, 11 May 2012 16:09:05 +0000 (12:09 -0400)]
Fixes a fixed-point overflow by scaling pitch search more conservatively

7 years agoMake it possible for the mono test to fail
Jean-Marc Valin [Fri, 11 May 2012 05:12:23 +0000 (01:12 -0400)]
Make it possible for the mono test to fail

7 years agoAddressing the remaining comments from Robert Sparks
Jean-Marc Valin [Thu, 10 May 2012 20:00:19 +0000 (16:00 -0400)]
Addressing the remaining comments from Robert Sparks

7 years agoIncrease alignment of the internal state structures to sizeof(void *) from 4 bytes.
Gregory Maxwell [Sat, 5 May 2012 00:01:56 +0000 (20:01 -0400)]
Increase alignment of the internal state structures to sizeof(void *) from 4 bytes.

OpusCustomMode begins with a pointer and was getting misaligned on 64 bit arches.

7 years agoMake opus_demo r/w little-endian PCM independent of host byte-order.
Gregory Maxwell [Mon, 30 Apr 2012 14:22:03 +0000 (10:22 -0400)]
Make opus_demo r/w little-endian PCM independent of host byte-order.

7 years agoFixes two fixed-point overflow issues
Jean-Marc Valin [Thu, 10 May 2012 16:36:46 +0000 (12:36 -0400)]
Fixes two fixed-point overflow issues

One in SILK, one in CELT, none of them causing real harm in practice it seems

7 years agoFixes a (harmless) float overflow in the pitch search
Jean-Marc Valin [Tue, 8 May 2012 17:58:57 +0000 (13:58 -0400)]
Fixes a (harmless) float overflow in the pitch search

7 years agoAvoid the unnecessary resynth averaging on intensity switch when encoding.
Gregory Maxwell [Sun, 6 May 2012 03:12:50 +0000 (23:12 -0400)]
Avoid the unnecessary resynth averaging on intensity switch when encoding.

Prevents some arithmetic on uninitialized memory that may contain nans.

7 years agoIncrease alignment of the internal state structures to sizeof(void *) from 4 bytes.
Gregory Maxwell [Sat, 5 May 2012 00:01:56 +0000 (20:01 -0400)]
Increase alignment of the internal state structures to sizeof(void *) from 4 bytes.

OpusCustomMode begins with a pointer and was getting misaligned on 64 bit arches.

7 years agoMake opus_demo r/w little-endian PCM independent of host byte-order.
Gregory Maxwell [Mon, 30 Apr 2012 14:22:03 +0000 (10:22 -0400)]
Make opus_demo r/w little-endian PCM independent of host byte-order.

7 years agoMake it possible for run_vectors.sh to fail on the mono tests.
Gregory Maxwell [Mon, 30 Apr 2012 08:13:20 +0000 (04:13 -0400)]
Make it possible for run_vectors.sh to fail on the mono tests.

7 years agoRemove automake color-tests and parallel-tests because they break solaris and require...
Gregory Maxwell [Mon, 30 Apr 2012 00:24:36 +0000 (20:24 -0400)]
Remove automake color-tests and parallel-tests because they break solaris and require much newer autotools.

This reverts commit a69368e1c0a028b50f1c00864d9c7c2f4527a089.

7 years agoReadme updates.
Gregory Maxwell [Wed, 25 Apr 2012 17:30:21 +0000 (13:30 -0400)]
Readme updates.

7 years agoFixes a (harmless) numerical overflow in noise_shape_analysis_FIX.c
Jean-Marc Valin [Wed, 25 Apr 2012 00:45:04 +0000 (20:45 -0400)]
Fixes a (harmless) numerical overflow in noise_shape_analysis_FIX.c

Actual behaviour was correct on most architectures and breaking that
code would have required a particularly smart compiler.

7 years agoUses opus_int32 for fs_API_Hz parameter in silk_decoder_set_fs
Jean-Marc Valin [Tue, 24 Apr 2012 21:18:58 +0000 (17:18 -0400)]
Uses opus_int32 for fs_API_Hz parameter in silk_decoder_set_fs

7 years agoChanges all uses of SHR()/SHL() macros to SHR32()/SHL32()
Jean-Marc Valin [Tue, 24 Apr 2012 21:12:25 +0000 (17:12 -0400)]
Changes all uses of SHR()/SHL() macros to SHR32()/SHL32()

7 years agoPrevents remove_doubling() from considering negative pitch gains
Jean-Marc Valin [Tue, 24 Apr 2012 21:00:54 +0000 (17:00 -0400)]
Prevents remove_doubling() from considering negative pitch gains

7 years agoAdd fwrite() error handling in repacketizer_demo.
Gregory Maxwell [Mon, 23 Apr 2012 17:52:00 +0000 (13:52 -0400)]
Add fwrite() error handling in repacketizer_demo.

7 years agoMinor comment formatting change
Gregory Maxwell [Tue, 24 Apr 2012 05:45:01 +0000 (01:45 -0400)]
Minor comment formatting change

7 years agoMerge commit '390c89225d'
Jean-Marc Valin [Tue, 24 Apr 2012 17:39:22 +0000 (13:39 -0400)]
Merge commit '390c89225d'

7 years agoMinor comment formatting change draft-12 v0.9.10
Gregory Maxwell [Tue, 24 Apr 2012 05:45:01 +0000 (01:45 -0400)]
Minor comment formatting change

7 years agoAdds 3rd clause to CELT license
Jean-Marc Valin [Mon, 23 Apr 2012 18:24:19 +0000 (14:24 -0400)]
Adds 3rd clause to CELT license

7 years agoAdds some references, bumps version number
Jean-Marc Valin [Tue, 24 Apr 2012 04:57:04 +0000 (00:57 -0400)]
Adds some references, bumps version number

7 years agoAddressing AD issues
Timothy B. Terriberry [Tue, 24 Apr 2012 04:37:04 +0000 (00:37 -0400)]
Addressing AD issues

Including a description of the PVQ encoder and decoder

7 years agoAdds note on monic filter
Jean-Marc Valin [Mon, 23 Apr 2012 20:24:45 +0000 (16:24 -0400)]
Adds note on monic filter

7 years agoFix negative write bug in opus_demo and add some fwrite() error handling.
Gregory Maxwell [Mon, 23 Apr 2012 17:51:23 +0000 (13:51 -0400)]
Fix negative write bug in opus_demo and add some fwrite() error handling.

7 years agos/FOUNDATION/COPYRIGHT OWNER/ in CELT code and "glue code"
Jean-Marc Valin [Fri, 20 Apr 2012 20:40:24 +0000 (16:40 -0400)]
s/FOUNDATION/COPYRIGHT OWNER/ in CELT code and "glue code"

Also added 3rd clause to "master" COPYING file

7 years agoLicense update using the IETF Trust flavour of the BSD on the Silk code
Jean-Marc Valin [Fri, 20 Apr 2012 20:31:04 +0000 (16:31 -0400)]
License update using the IETF Trust flavour of the BSD on the Silk code

7 years agoMore changes addressing Robert Sparks' review
Timothy B. Terriberry [Fri, 20 Apr 2012 19:47:37 +0000 (15:47 -0400)]
More changes addressing Robert Sparks' review

7 years agoMisc changes to address Robert Sparks' comments
Jean-Marc Valin [Fri, 20 Apr 2012 14:26:08 +0000 (10:26 -0400)]
Misc changes to address Robert Sparks' comments

See http://www.ietf.org/mail-archive/web/codec/current/msg02833.html
Still more changes to come

7 years agooops, this removes dead code left from previous commit
Jean-Marc Valin [Fri, 13 Apr 2012 16:29:51 +0000 (12:29 -0400)]
oops, this removes dead code left from previous commit

7 years agoMakes silk_ADD_SAT32() conform to the C standard
Jean-Marc Valin [Thu, 12 Apr 2012 20:35:19 +0000 (16:35 -0400)]
Makes silk_ADD_SAT32() conform to the C standard

This changes the saturation test to ensure that it relies on the
unsigned overflow behaviour (which is allowed) rather than the signed
overflow behaviour (which is undefined).

7 years agoFixes several overflows in the CELT fixed-point
Jean-Marc Valin [Thu, 12 Apr 2012 15:07:21 +0000 (11:07 -0400)]
Fixes several overflows in the CELT fixed-point

These were all mostly benign and would at worst result in (rare)
suboptimal encoder decisions rather than signal corruption.

7 years agoFixes a bug introduced by the previous commit
Jean-Marc Valin [Sun, 8 Apr 2012 03:03:24 +0000 (23:03 -0400)]
Fixes a bug introduced by the previous commit

celt_ilog2() could be called with 0 which is undefined.

7 years agoFixes some overflows in the fixed-point pitch code
Jean-Marc Valin [Sat, 7 Apr 2012 03:32:11 +0000 (23:32 -0400)]
Fixes some overflows in the fixed-point pitch code

The overflows reported were:
- Syy in find_best_pitch() in pitch.c
- xy, xx and yy in remove_doubling() in pitch.c

The fixes are:
- Adaptive scaling in pitch_downsample() which also improves quality
- Adding a missing downshift in find_best_pitch()
- More conservative yshift when calling find_best_pitch()

7 years agoRename to header makefile fragements to .mk
Ralph Giles [Thu, 5 Apr 2012 16:23:47 +0000 (09:23 -0700)]
Rename to header makefile fragements to .mk

The opus_headers.txt, etc. files are makefile
fragments defining variables with a list of
required header files for the build. As such
they should use the .mk filename extension,
just like opus_sources.mk, etc.

7 years agoAdd opus_custom.h to celt_headers.txt.
Ralph Giles [Thu, 5 Apr 2012 16:19:25 +0000 (09:19 -0700)]
Add opus_custom.h to celt_headers.txt.

This file is included unconditionally by celt.h.
As such it's a required part of the build and
should be in the header index files.

7 years agoCast a factor to maintain precision on 16 bit systems.
Ralph Giles [Thu, 22 Mar 2012 21:13:33 +0000 (14:13 -0700)]
Cast a factor to maintain precision on 16 bit systems.

The multiply would overflow with 16 bit ints. Thanks
to Riccardo Micci for pointing out the issue. Thanks
to Tim Terriberry for the valid range of the decay
argument.

Note that ft is unsigned, but always less than 32736,
so we could use a 16 bit signed type here if it allows
the compiler to produce faster code (with signed 16*16
and 16*32 multiplies). In the absense of actual cycle
counts from a real platform, I've left it as an unsigned
for the sake of readability.

For similar reasons we cast (16384-decay) to a signed
integer even though it is also always positive.

7 years agoImprove decoder_create documentation.
Ralph Giles [Thu, 22 Mar 2012 20:29:04 +0000 (13:29 -0700)]
Improve decoder_create documentation.

The parameter descriptions look like they were copied
from encoder_create. Update them for the decode side
and repeat the clarifications about what sample rates
are allowed and what they mean.