Assert non-overlapping memcpy. r=mark4o
authorRalph Giles <giles@mozilla.com>
Mon, 4 Jul 2016 17:39:31 +0000 (10:39 -0700)
committerRalph Giles <giles@mozilla.com>
Mon, 4 Jul 2016 17:39:31 +0000 (10:39 -0700)
Coverity warns about the possibly-overlappying memcpy in this
block, presumedly because it can't prove predictLPCOrder <= MAX_LPC_ORDER
here. Add an assert to make the intent clear in code as well
as in the comment.

silk/process_NLSFs.c

index c27cf03..248000b 100644 (file)
@@ -100,6 +100,7 @@ void silk_process_NLSFs(
 
     } else {
         /* Copy LPC coefficients for first half from second half */
+        silk_assert( psEncC->predictLPCOrder <= MAX_LPC_ORDER );
         silk_memcpy( PredCoef_Q12[ 0 ], PredCoef_Q12[ 1 ], psEncC->predictLPCOrder * sizeof( opus_int16 ) );
     }
 }