opus.git
2 years agoFix folding bug in draft too
Jean-Marc Valin [Mon, 4 Jul 2016 19:44:30 +0000 (15:44 -0400)]
Fix folding bug in draft too

2 years agoAssert non-overlapping memcpy. r=mark4o
Ralph Giles [Mon, 4 Jul 2016 17:39:31 +0000 (10:39 -0700)]
Assert non-overlapping memcpy. r=mark4o

Coverity warns about the possibly-overlappying memcpy in this
block, presumedly because it can't prove predictLPCOrder <= MAX_LPC_ORDER
here. Add an assert to make the intent clear in code as well
as in the comment.

2 years agoForgot to call RESTORE_STACK in 328953e1896432bc700b9b5c69ae2987c5d752f4
Jean-Marc Valin [Mon, 4 Jul 2016 14:45:15 +0000 (10:45 -0400)]
Forgot to call RESTORE_STACK in 328953e1896432bc700b9b5c69ae2987c5d752f4

2 years agoupdate draft fixes
Jean-Marc Valin [Mon, 4 Jul 2016 14:42:45 +0000 (10:42 -0400)]
update draft fixes

2 years agoMaking calls to opus_packet_pad() on a bad packet return OPUS_INVALID_PACKET
Jean-Marc Valin [Mon, 4 Jul 2016 05:29:23 +0000 (01:29 -0400)]
Making calls to opus_packet_pad() on a bad packet return OPUS_INVALID_PACKET

We were previously returning OPUS_BAD_ARG because the failure was
only detected in opus_repacketizer_out_range_impl() rather than in
opus_repacketizer_cat(). Checking the return value from opus_repacketizer_cat()
also addresses the last outstanding Coverity defect.

2 years agominor update draft update
Jean-Marc Valin [Fri, 1 Jul 2016 20:09:19 +0000 (16:09 -0400)]
minor update draft update

2 years agoAdding hybrid folding section and new testvectors to the update draft
Jean-Marc Valin [Thu, 30 Jun 2016 22:01:04 +0000 (18:01 -0400)]
Adding hybrid folding section and new testvectors to the update draft

2 years agoFix build error from comma at end of enum
Michael Graczyk [Thu, 30 Jun 2016 03:30:19 +0000 (20:30 -0700)]
Fix build error from comma at end of enum

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
2 years agoAddressing more issues from scan-build
Jean-Marc Valin [Thu, 30 Jun 2016 03:16:51 +0000 (23:16 -0400)]
Addressing more issues from scan-build

2 years agoAddress static analysis reports from scan-build
Jean-Marc Valin [Thu, 30 Jun 2016 03:11:57 +0000 (23:11 -0400)]
Address static analysis reports from scan-build

2 years agoAdd static bitrate allocation and force CELT-only for ambisonics encoding
Michael Graczyk [Tue, 5 Apr 2016 02:31:04 +0000 (19:31 -0700)]
Add static bitrate allocation and force CELT-only for ambisonics encoding

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
2 years agoAdd experimental support for ambisonic encoding
Michael Graczyk [Tue, 3 May 2016 04:42:18 +0000 (21:42 -0700)]
Add experimental support for ambisonic encoding

The implementation currently only codes each channel independently with no
special allocation rules.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
2 years agoFixes an invalid read in compute_stereo_width() for 2.5 ms frames at 12 kHz
Jean-Marc Valin [Tue, 28 Jun 2016 03:44:18 +0000 (23:44 -0400)]
Fixes an invalid read in compute_stereo_width() for 2.5 ms frames at 12 kHz

That's the only size that's not a multiple of 4, so we just discard 2 samples
from the calculation.

2 years agoFixes minor code quality issues in CELT
Jean-Marc Valin [Mon, 20 Jun 2016 16:11:05 +0000 (12:11 -0400)]
Fixes minor code quality issues in CELT

Reported by Durandal.

2 years agoFixes potential overflow on 16-bit platforms
Jean-Marc Valin [Mon, 20 Jun 2016 16:09:52 +0000 (12:09 -0400)]
Fixes potential overflow on 16-bit platforms

Reported by Durandal.

2 years agoFixes signed integer overflow in fixed-point Burg
Jean-Marc Valin [Sun, 19 Jun 2016 18:44:55 +0000 (14:44 -0400)]
Fixes signed integer overflow in fixed-point Burg

We just explicitly allow the overflow with silk_MLA_ovflw() since the result
seems to be correct because the overflows cancel each other.

3 years agoFixes a fixed-point precision issue in remove_doubling()
Jean-Marc Valin [Sat, 18 Jun 2016 15:15:25 +0000 (11:15 -0400)]
Fixes a fixed-point precision issue in remove_doubling()

This could lead to an integer overflow. Also, refactored the code a bit

3 years agoFixes an overflow in the constrained VBR code for bitrate>64000
Jean-Marc Valin [Sat, 18 Jun 2016 00:58:30 +0000 (20:58 -0400)]
Fixes an overflow in the constrained VBR code for bitrate>64000

3 years agoSaturate when adding prediction to LPC excitation to avoid integer overflow
Felicia Lim [Sat, 4 Jun 2016 14:10:52 +0000 (10:10 -0400)]
Saturate when adding prediction to LPC excitation to avoid integer overflow

Slightly modified by Jean-Marc Valin

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
3 years agoUpdate ISO Base Media Format draft to version 0.6.8.
Ralph Giles [Thu, 2 Jun 2016 21:13:32 +0000 (14:13 -0700)]
Update ISO Base Media Format draft to version 0.6.8.

3 years agoList intrinsics flags being tested after existing cflags, so they override other...
Jonathan Lennox [Tue, 31 May 2016 19:52:37 +0000 (15:52 -0400)]
List intrinsics flags being tested after existing cflags, so they override other options.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
3 years agoModify autoconf tests for intrinsics to stop clang from optimizing them away.
Jonathan Lennox [Tue, 31 May 2016 19:52:36 +0000 (15:52 -0400)]
Modify autoconf tests for intrinsics to stop clang from optimizing them away.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
3 years agoAdd remaining generated files to gitignore
Ricardo Constantino (:RiCON) [Wed, 18 May 2016 20:22:32 +0000 (21:22 +0100)]
Add remaining generated files to gitignore

*-gnu.S are generated by arm2gnu.pl (derf)
celt/arm/armopts.s is also generated from armopts.s.in

3 years agoClean doxygen_sqlite3.db
Ricardo Constantino (:RiCON) [Wed, 18 May 2016 19:58:58 +0000 (20:58 +0100)]
Clean doxygen_sqlite3.db

Generated by newer versions of Doxygen when built with sqlite3.

3 years agoMove .exe back to root .gitignore for mingw builds
Ricardo Constantino (:RiCON) [Wed, 18 May 2016 19:21:05 +0000 (20:21 +0100)]
Move .exe back to root .gitignore for mingw builds

3 years agoUpdate EXTRA_DIST to ship the VS2015 project files.
Ralph Giles [Wed, 18 May 2016 19:24:15 +0000 (12:24 -0700)]
Update EXTRA_DIST to ship the VS2015 project files.

Thanks to derf for the report.

3 years agoRemove VS2010 project files.
Ralph Giles [Wed, 18 May 2016 18:53:58 +0000 (11:53 -0700)]
Remove VS2010 project files.

Visual Studio 2015 has been out for a while, and has a gratis
version. It doesn't make sense to maintain parallel support
for older releases.

3 years agoMove Visual Studio GitIgnores to own file
Orestes Zoupanos [Tue, 17 May 2016 22:08:40 +0000 (23:08 +0100)]
Move Visual Studio GitIgnores to own file

3 years agoFix DLL errors and Additional Library Directories
Orestes Zoupanos [Tue, 17 May 2016 22:06:54 +0000 (23:06 +0100)]
Fix DLL errors and Additional Library Directories

3 years agoFix VS2015 dynamic builds by adding DLL_EXPORT to CFLAGS
Ricardo Constantino (:RiCON) [Wed, 20 Apr 2016 18:40:10 +0000 (19:40 +0100)]
Fix VS2015 dynamic builds by adding DLL_EXPORT to CFLAGS

Needed after 6e96173.

3 years agoRemove redundant .gitignore entries.
Ralph Giles [Wed, 11 May 2016 22:59:26 +0000 (15:59 -0700)]
Remove redundant .gitignore entries.

3 years agoBetter Git Ignores for Visual Studio. r=rillian
Orestes Zoupanos [Wed, 11 May 2016 21:11:27 +0000 (22:11 +0100)]
Better Git Ignores for Visual Studio. r=rillian

3 years agoDon't ignore win32.
Ralph Giles [Wed, 11 May 2016 22:50:25 +0000 (15:50 -0700)]
Don't ignore win32.

This was adding in the MSVC project updates, but isn't correct.

3 years agofix build settings for DLL project, runtime library must be linked to DLL too to...
uraymeiviar [Fri, 6 Nov 2015 15:25:25 +0000 (22:25 +0700)]
fix build settings for DLL project, runtime library must be linked to DLL too to prevent heap deallocation error

3 years agoAdded Visual Studio 2015 solution and added ReleaseDLL and DebugDLL Project settings...
uraymeiviar [Fri, 6 Nov 2015 14:58:25 +0000 (21:58 +0700)]
Added Visual Studio 2015 solution and added ReleaseDLL and DebugDLL Project settings to produce .dll file instead of .lib

3 years agoFixes floating-point bug introduced in be9e747bcc542c277d30f6c78a57b0940e0c5b5e
Jean-Marc Valin [Fri, 22 Apr 2016 19:10:13 +0000 (15:10 -0400)]
Fixes floating-point bug introduced in be9e747bcc542c277d30f6c78a57b0940e0c5b5e

The effect was to always set HB_gain to 1.

3 years agowin32: only use dllexport when building DLL
Daniel Verkamp [Thu, 22 Oct 2015 00:24:41 +0000 (17:24 -0700)]
win32: only use dllexport when building DLL

If building a static library, marking symbols as dllexport causes them
to be exported from the final executable. For example, run
objdump -x opus_demo.exe on a --disabled-shared build and look for the
export table; there should not be one in a normal Win32 .exe file, but
when linking static libopus, the exe exports all of the opus_* public
functions.

Use the libtool-defined DLL_EXPORT flag to determine whether we are
building a DLL and only specify __declspec(dllexport) in that case.

3 years agoTurn on CELT's PLC only if there are >=2 packets received consecutively.
Felicia Lim [Wed, 6 Apr 2016 09:23:21 +0000 (11:23 +0200)]
Turn on CELT's PLC only if there are >=2 packets received consecutively.

Avoids generating comfort noise with unwanted tones in DTX mode.

3 years agocng exitation signal can saturate. Use same scaling as PLC and normal decoding
Soren Skak Jensen [Tue, 15 Mar 2016 13:51:28 +0000 (14:51 +0100)]
cng exitation signal can saturate. Use same scaling as PLC and normal decoding

3 years agoFix valgrind unaddressable mem read error
Felicia Lim [Wed, 30 Mar 2016 13:11:06 +0000 (15:11 +0200)]
Fix valgrind unaddressable mem read error

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
3 years agoFixes overflows on CPUs with 16-bit ints
Jean-Marc Valin [Mon, 21 Mar 2016 17:11:48 +0000 (13:11 -0400)]
Fixes overflows on CPUs with 16-bit ints

As reported by Giovanni Rovatti, this should fix some TI C55 issues.

3 years agofix for divide by zero
Felicia Lim [Fri, 18 Mar 2016 00:52:05 +0000 (08:52 +0800)]
fix for divide by zero

3 years agooggopus: Update version and date for -14
Timothy B. Terriberry [Tue, 23 Feb 2016 01:51:03 +0000 (17:51 -0800)]
oggopus: Update version and date for -14

3 years agooggopus: Address Barry Leiba's IESG comments.
Timothy B. Terriberry [Thu, 18 Feb 2016 02:24:35 +0000 (18:24 -0800)]
oggopus: Address Barry Leiba's IESG comments.

Thanks to Barry for proposing specific text for the changes.

3 years agooggopus: Fix page numbers in example diagram.
Timothy B. Terriberry [Thu, 18 Feb 2016 01:31:49 +0000 (17:31 -0800)]
oggopus: Fix page numbers in example diagram.

Ralph Giles correctly points out that the sequence number field in
 Ogg pages starts couting at 0, so counting from 1 in the diagram
 might be confusing.

3 years agooggopus: Update Wikipedia URLs.
Timothy B. Terriberry [Thu, 18 Feb 2016 01:30:15 +0000 (17:30 -0800)]
oggopus: Update Wikipedia URLs.

For RFC 6716, the RFC Editor converted our Wikipedia URLs into
 stable ones that would always point at the same version of the
 page.
We're close enough to the end that we can go ahead and do that in
 advance (and also update the dates to reflect the most recent
 version).

3 years agooggopus: Fix typo.
Ralph Giles [Wed, 17 Feb 2016 10:13:23 +0000 (02:13 -0800)]
oggopus: Fix typo.

3 years agooggopus: Address Stephen Farrell's IESG comments.
Timothy B. Terriberry [Wed, 17 Feb 2016 02:05:10 +0000 (18:05 -0800)]
oggopus: Address Stephen Farrell's IESG comments.

- Clarify that 125,829,120 is just 120 MB.
- Add a figure to Section 3 of an example logical stream.
- Add a reference for Q notation.
- Refer to the downmixing figures in the text.
- Clarify that user comments are UTF-8.
- Clarify that the -573 and 111 gain values are examples.
- Add specific advice to implementors on areas that have security
   implications.

3 years agooggopus: Update version and date for -13
Timothy B. Terriberry [Fri, 12 Feb 2016 21:02:02 +0000 (13:02 -0800)]
oggopus: Update version and date for -13

Apparently the IETF does not like having the BSD copyright in the
 .xml source (despite the CODEC WG's IPR advisor saying this was
 okay), so we need a new version.

3 years agoRemove unused patch file.
Ralph Giles [Tue, 9 Feb 2016 17:49:16 +0000 (09:49 -0800)]
Remove unused patch file.

It looks like this was included accidentally.

Thanks to mark4o for pointing out I'd missed this in the previous
removal.

3 years agoExpand SILK macro to avoid "Wexpansion-to-defined" violation
flim [Tue, 9 Feb 2016 14:59:57 +0000 (15:59 +0100)]
Expand SILK macro to avoid "Wexpansion-to-defined" violation

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
3 years agoRemove unused patch file.
Ralph Giles [Wed, 3 Feb 2016 20:36:17 +0000 (12:36 -0800)]
Remove unused patch file.

It looks like this was included accidentally.

3 years agoRemove generation date from docs.
Ralph Giles [Wed, 3 Feb 2016 20:32:00 +0000 (12:32 -0800)]
Remove generation date from docs.

The improves the reproducibilit of the build. The date
was nice to have, but there's a version string at the
top which should identify the release correctly.

The copyright date could actually be incorrect, since
it is based on the build date and not the last-changed
date.

3 years agoClean up footer.html.
Ralph Giles [Wed, 3 Feb 2016 20:28:22 +0000 (12:28 -0800)]
Clean up footer.html.

Use https urls.
Indent nesting levels and add missing </td>.

3 years agooggopus: Additional minor rewording.
Timothy B. Terriberry [Wed, 3 Feb 2016 13:42:22 +0000 (05:42 -0800)]
oggopus: Additional minor rewording.

Hopefully this is even clearer.
Thanks again to Mark Harris for the suggestion.

3 years agooggopus: Update version and date for -12
Timothy B. Terriberry [Wed, 3 Feb 2016 06:18:11 +0000 (22:18 -0800)]
oggopus: Update version and date for -12

3 years agooggopus: Minor rewording.
Timothy B. Terriberry [Wed, 3 Feb 2016 06:11:35 +0000 (22:11 -0800)]
oggopus: Minor rewording.

This avoids the claim that all possible Opus implementations would
 run at rates that divide 48 kHz.
Thanks to Mark Harris for raising the issue.

3 years agooggopus: Update the acknowledgements.
Timothy B. Terriberry [Wed, 3 Feb 2016 06:05:02 +0000 (22:05 -0800)]
oggopus: Update the acknowledgements.

3 years agooggopus: Add a BSD license header.
Timothy B. Terriberry [Wed, 3 Feb 2016 06:00:49 +0000 (22:00 -0800)]
oggopus: Add a BSD license header.

This also removes the request for an additional grant from the IETF
 Trust on the final RFC.
I believe this is sufficient to exercise our ability to allow
 downstream modifications as proposed in RFC 5377 Section 4.4.
See the discussion at
 <https://www.ietf.org/mail-archive/web/codec/current/msg03169.html>
 for details.

3 years agooggopus: Revert reference to RFC 4732 back to informative.
Timothy B. Terriberry [Thu, 28 Jan 2016 21:37:44 +0000 (13:37 -0800)]
oggopus: Revert reference to RFC 4732 back to informative.

Thanks to Ron Lee for the suggestion.

3 years agooggopus: Update version and date for -11
Timothy B. Terriberry [Thu, 28 Jan 2016 18:34:49 +0000 (10:34 -0800)]
oggopus: Update version and date for -11

3 years agooggopus: Specify that the new IANA registry is top-level.
Timothy B. Terriberry [Thu, 28 Jan 2016 18:30:20 +0000 (10:30 -0800)]
oggopus: Specify that the new IANA registry is top-level.

Thanks to Sabrina Tanamal for pointing out the ambiguity.

3 years agoRemove default settings from Doxygen config.
Ralph Giles [Fri, 15 Jan 2016 23:59:30 +0000 (15:59 -0800)]
Remove default settings from Doxygen config.

The set of supported Doxygenfile keys changes from release
to release, often resulting in warnings about needing to
upgrade the configuration file. However, this isn't
practical given the various versions different developers
have installed.

However, for the vast majority of keys we just want the
default values, so instead only include the keys we've
specifically set and let doxygen fall back to defaults
for all the rest.

3 years agoDocuemnt the source of the 2.5 ms and 48 kHz restrictions.
Timothy B. Terriberry [Fri, 15 Jan 2016 23:57:49 +0000 (15:57 -0800)]
Docuemnt the source of the 2.5 ms and 48 kHz restrictions.

Thanks to Joel Halpern for the suggestion.

3 years agooggopus: Fix continued packet lacing reference.
Ralph Giles [Fri, 15 Jan 2016 23:30:46 +0000 (15:30 -0800)]
oggopus: Fix continued packet lacing reference.

Thanks to Joel Halpern for pointing out the discrepancy.

3 years agoAdd /topic update to release checklist
Mark Harris [Thu, 14 Jan 2016 05:09:35 +0000 (21:09 -0800)]
Add /topic update to release checklist

3 years agooggdraft: Update version and date for -10
Timothy B. Terriberry [Tue, 12 Jan 2016 21:36:58 +0000 (13:36 -0800)]
oggdraft: Update version and date for -10

3 years agooggdraft: Fix typo.
Timothy B. Terriberry [Tue, 12 Jan 2016 21:36:01 +0000 (13:36 -0800)]
oggdraft: Fix typo.

Thanks to Ben Campbell for the report.

3 years agooggopus: Remove normative language from IANA registry.
Timothy B. Terriberry [Tue, 12 Jan 2016 21:12:22 +0000 (13:12 -0800)]
oggopus: Remove normative language from IANA registry.

From AD review.

3 years agooggopus: Replace 'reject' with 'treat as invalid'.
Timothy B. Terriberry [Tue, 12 Jan 2016 21:08:27 +0000 (13:08 -0800)]
oggopus: Replace 'reject' with 'treat as invalid'.

From AD review.

3 years agoupdate releases.sha2
Jean-Marc Valin [Tue, 12 Jan 2016 19:00:02 +0000 (14:00 -0500)]
update releases.sha2

3 years agobump libtool revision for 1.1.2
Jean-Marc Valin [Tue, 12 Jan 2016 18:13:13 +0000 (13:13 -0500)]
bump libtool revision for 1.1.2

3 years agoSuggest OPUS_LSB_DEPTH(14) for G.711. r=td-linux,mark4o
Ralph Giles [Thu, 7 Jan 2016 19:43:47 +0000 (11:43 -0800)]
Suggest OPUS_LSB_DEPTH(14) for G.711. r=td-linux,mark4o

This is a reasonable choice for the (non-linear) dynamic
range of mu-law. A-law is technically 13 bit, maybe 12;
experimentation is needed.

Per irc discussion with Jean-Marc, Ron, and Mark Harris.

3 years agoAdd checksums for opusfile 0.7.
Ralph Giles [Wed, 6 Jan 2016 01:54:35 +0000 (17:54 -0800)]
Add checksums for opusfile 0.7.

Also alphabetize the rest of the file.

3 years agoAdd a check target to the static makefiles. r=ron
Ralph Giles [Tue, 29 Dec 2015 07:37:49 +0000 (23:37 -0800)]
Add a check target to the static makefiles. r=ron

3 years agoAdd 'force' to the phony target list. r=ron
Ralph Giles [Tue, 29 Dec 2015 07:30:29 +0000 (23:30 -0800)]
Add 'force' to the phony target list. r=ron

3 years agoRenamed MAX_PULSES to SILK_MAX_PULSES and CELT_MAX_PULSES
Jean-Marc Valin [Thu, 31 Dec 2015 19:43:49 +0000 (14:43 -0500)]
Renamed MAX_PULSES to SILK_MAX_PULSES and CELT_MAX_PULSES

Avoids accidental name collisions

3 years agoActually fix pedantic build bustage.
Timothy B. Terriberry [Thu, 31 Dec 2015 13:56:45 +0000 (05:56 -0800)]
Actually fix pedantic build bustage.

3 years agoFix pedantic build bustage.
Timothy B. Terriberry [Thu, 31 Dec 2015 13:00:31 +0000 (05:00 -0800)]
Fix pedantic build bustage.

ISO C90 forbids mixed declarations and code, r=bustage

3 years agoAdd tonality_analysis_reset().
Ralph Giles [Wed, 30 Dec 2015 23:27:02 +0000 (15:27 -0800)]
Add tonality_analysis_reset().

Add a reset function for the TonalityAnalysisState struct
and call it on encoder reset.

Move the state struct above the clear line in OpusEncoder
so reset doesn't clobber reusable fields. Currently this
is only the arch field, which is moved to to top of the
struct so we can use the same memset-to-the-end pattern
as OpusEncoder.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
3 years agoAdd an initializer for TonalityAnalysisState.
Ralph Giles [Wed, 30 Dec 2015 18:00:17 +0000 (10:00 -0800)]
Add an initializer for TonalityAnalysisState.

This interns the asm flags parameter in the state struct
so we don't need to pass it with every call. It can be
expensive, so we don't want to query every run_analysis()
call, but since this (private) api is used by webrtc code
we need to provide a supportable interface for filling in
the correct value.

Note the initialization code is partially duplicated between
opus_encoder_init and the OPUS_RESET_STATE switch case, so we
must re-initialize it there.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>
3 years agoRemove unused encoder field analysis_offset
Mark Harris [Wed, 30 Dec 2015 19:37:20 +0000 (11:37 -0800)]
Remove unused encoder field analysis_offset

3 years agoAvoids having the Opus-level "arch" be set to 0 on encoder/decoder reset
Jean-Marc Valin [Wed, 30 Dec 2015 19:21:34 +0000 (14:21 -0500)]
Avoids having the Opus-level "arch" be set to 0 on encoder/decoder reset

3 years agooggopus: More updates for AD review comments.
Timothy B. Terriberry [Mon, 28 Dec 2015 12:54:55 +0000 (04:54 -0800)]
oggopus: More updates for AD review comments.

Removed 2119 language for general Ogg requirements.
Added IANA registry for channel mapping families.
Adjusted additional copyright grant to match RFC 6716.
Additional comments addressed (see the CODEC mailing list).

3 years agoFixes patch_transient_decision() for hybrid mode
Jean-Marc Valin [Fri, 4 Dec 2015 21:42:19 +0000 (16:42 -0500)]
Fixes patch_transient_decision() for hybrid mode

...and also make it not ignore the right channel

3 years agoOops, fixes max_decay for LFE in fixed-point
Jean-Marc Valin [Sat, 28 Nov 2015 07:35:21 +0000 (02:35 -0500)]
Oops, fixes max_decay for LFE in fixed-point

3 years agooggopus: Revert SHOULD->MUST for reserved mappings.
Timothy B. Terriberry [Fri, 11 Dec 2015 22:11:00 +0000 (14:11 -0800)]
oggopus: Revert SHOULD->MUST for reserved mappings.

Mark Harris convinced me that the significant delay between "WG
 consensus" and "RFC" means we shouldn't rely on RFC updates to
 give people permission to start deploying new things.

3 years agooggopus: Fix typo.
Timothy B. Terriberry [Fri, 11 Dec 2015 19:41:36 +0000 (11:41 -0800)]
oggopus: Fix typo.

Thanks to Mark Harris for the report.

3 years agooggopus: First pass updates for AD review comments.
Timothy B. Terriberry [Fri, 11 Dec 2015 19:30:06 +0000 (11:30 -0800)]
oggopus: First pass updates for AD review comments.

3 years agoMake the CELT background noise estimator adapt more quickly on DTX update
Jean-Marc Valin [Fri, 4 Dec 2015 21:11:39 +0000 (16:11 -0500)]
Make the CELT background noise estimator adapt more quickly on DTX update

3 years agoopus_demo: fixes potential division by zero on files with no active frame
Jean-Marc Valin [Fri, 4 Dec 2015 19:40:50 +0000 (14:40 -0500)]
opus_demo: fixes potential division by zero on files with no active frame

3 years agoFixes memory leak in some CELT unit tests
Jean-Marc Valin [Fri, 4 Dec 2015 19:35:18 +0000 (14:35 -0500)]
Fixes memory leak in some CELT unit tests

Reported in https://trac.xiph.org/ticket/2241

3 years agoAlways use the max of the decaying PLC energy and the background noise
Jean-Marc Valin [Thu, 3 Dec 2015 18:32:10 +0000 (13:32 -0500)]
Always use the max of the decaying PLC energy and the background noise

Should no longer cause discontinuities in the noise after 5 packets

3 years agoFixes the transient detector on silence
Jean-Marc Valin [Thu, 3 Dec 2015 19:12:01 +0000 (14:12 -0500)]
Fixes the transient detector on silence

Previously silence would cause the divide approximation on 0/0 to return a
very large value, which would be interpreted as a transient

3 years agoupdate sha256 in repo
Jean-Marc Valin [Wed, 25 Nov 2015 21:13:18 +0000 (16:13 -0500)]
update sha256 in repo

3 years agobump libtool revision
Jean-Marc Valin [Wed, 25 Nov 2015 02:20:32 +0000 (21:20 -0500)]
bump libtool revision

3 years agooggopus: Fix spelling
Mark Harris [Tue, 24 Nov 2015 19:10:20 +0000 (11:10 -0800)]
oggopus: Fix spelling

3 years agoBump draft version and date for submission.
Timothy B. Terriberry [Tue, 24 Nov 2015 04:56:09 +0000 (20:56 -0800)]
Bump draft version and date for submission.

3 years agoAdditional edits from Mark Harris.
Timothy B. Terriberry [Tue, 24 Nov 2015 04:54:56 +0000 (20:54 -0800)]
Additional edits from Mark Harris.

3 years agoAddress remaining document shepherd review comments.
Timothy B. Terriberry [Tue, 24 Nov 2015 01:32:28 +0000 (17:32 -0800)]
Address remaining document shepherd review comments.

Also remove most <preamble>/<postamble> usage for expository text,
 as most places center the result, which looks ugly (only local
 xml2rfc HTML output does not center: tools.ietf.org HTML output
 still does, as does the .txt version).