Fix a regression that severely impacted compression levels.
authorErik de Castro Lopo <erikd@mega-nerd.com>
Fri, 12 Oct 2012 11:02:49 +0000 (22:02 +1100)
committerErik de Castro Lopo <erikd@mega-nerd.com>
Fri, 12 Oct 2012 11:02:49 +0000 (22:02 +1100)
commitfc360735ce4d1aa88a94bfccdd3bea5bdd19a8d6
tree63d207af1e688bd1c51c43d736482b33e3d8e817
parenta2923e64c0c1db21134f0e9a143fe0ac5597fa19
Fix a regression that severely impacted compression levels.

Regression was introducted in commit 8bbbf56403808ff75126cd0840a936aedbc4113b
(Feb 1 19:58:09 2012) when fixing compiler warnings. In src/libFLAC/lpc.c the
line:

        ref[i] = (r/=err);

was erroniously removed because the left hand side, ref[i] was never used.
Obviously, the correct thing to do was to replace that line with:

        r /= err;

This code has not been officially released. The only people who would have
been affected are people who compiled FLAC from git between February and
now.

The only adverse affect of this error was that compression ratio would have
been severely compromised. No audio is lost, and if anyone has a file that
compressed with a bad version of FLAC can decompress it to WAV and then
re-compress with a fixed version.
src/libFLAC/lpc.c